Skip to content

chore: type in GetGameInfoAndUserProgress is nullable #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2024
Merged

chore: type in GetGameInfoAndUserProgress is nullable #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec8889
chore: change `guideUrl` to nullable type
official-wizard Aug 24, 2024
c930b9b
version change
official-wizard Aug 24, 2024
74a2a56
chore: fix nullables
official-wizard Aug 24, 2024
c4699dd
chore: fix nullables
official-wizard Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>org.retroachievements</groupId>
<artifactId>api-kotlin</artifactId>
<version>1.0.8</version>
<version>1.0.9</version>

<dependencyManagement>
<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/org/retroachivements/api/RetroInterface.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ interface RetroInterface {
@POST("/API/API_GetUserProgress.php")
suspend fun getUserProgress(
@Query("u") username: String,
@Query("i") gameId: Long
@Query("i") gameId: String
): NetworkResponse<GetUserProgress.Response, ErrorResponse>

/**
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/org/retroachivements/api/data/pojo/game/GetGameExtended.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class GetGameExtended {
val pointsTotal: Long,

@SerializedName("GuideUrl")
val guideUrl: String,
val guideUrl: String?,

@SerializedName("Updated")
val updated: String,
Expand All @@ -72,7 +72,7 @@ class GetGameExtended {
val consoleName: String,

@SerializedName("ParentGameID")
val parentGameId: String,
val parentGameId: String?,

@SerializedName("NumDistinctPlayers")
val numDistinctPlayers: Long,
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/org/retroachivements/api/data/pojo/game/GetGameInfoAndUserProgress.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class GetGameInfoAndUserProgress {
val playersTotal: Int,

@SerializedName("GuideUrl")
val guideUrl: String,
val guideUrl: String?,

@SerializedName("ConsoleName")
val consoleName: String,
Expand Down Expand Up @@ -130,7 +130,7 @@ class GetGameInfoAndUserProgress {
val memAddr: String,

@SerializedName("Type")
val type: String,
val type: String?,

@SerializedName("DateEarnedHardcore")
val dateEarnedHardcore: String?,
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/org/retroachivements/api/data/pojo/ticket/GetMostRecentTickets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,10 @@ class GetMostRecentTickets {
val reportedBy: String,

@SerializedName("ResolvedAt")
val resolvedAt: String,
val resolvedAt: String?,

@SerializedName("ResolvedBy")
val resolvedBy: String,
val resolvedBy: String?,

@SerializedName("ReportStateDescription")
val reportStateDescription: String,
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/org/retroachivements/api/data/pojo/ticket/GetTicketData.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ class GetTicketData {
val reportedBy: String,

@SerializedName("ResolvedAt")
val resolvedAt: String,
val resolvedAt: String?,

@SerializedName("ResolvedBy")
val resolvedBy: String,
val resolvedBy: String?,

@SerializedName("ReportStateDescription")
val reportStateDescription: String,
Expand Down