Skip to content

Conversation

renao
Copy link
Contributor

@renao renao commented Feb 5, 2025

Hello 🙂

I just figured out by fiddling around with this great api that the datatype of the isFinal field might have changed and the API now returns a Boolean instead of an Int.

After that my calls via getGameInfoAndUserProgress won't fail anymore with any serialization exception.

Cheers

@official-wizard
Copy link
Member

Thank you for looking into this, strange it was changed I was told recently they wouldn't change ints to booleans for compatibility purposes & the documentations still display them as being an integer:

https://github.com/RetroAchievements/api-docs/blob/4052504fd9e2ad51cd6654983ba9c5d03fb5f890/docs/v1/get-game-info-and-user-progress.md

@wescopeland should I update the api docs?

@official-wizard official-wizard self-assigned this Feb 5, 2025
@official-wizard official-wizard added the bug Something isn't working label Feb 5, 2025
@official-wizard
Copy link
Member

Seems to be a recent change:

https://github.com/RetroAchievements/RAWeb/blob/7ca819372a102475c5e6303a4647ee3aecd15238/public/API/API_GetGameInfoAndUserProgress.php

I'm not sure if it was an accident that it was changed to a boolean in the process of deprecating the column/value.

@wescopeland
Copy link
Member

It was most likely an accident. Please feel free to update the API docs!

@official-wizard official-wizard merged commit 5296b29 into RetroAchievements:main Feb 5, 2025
@official-wizard
Copy link
Member

It was most likely an accident. Please feel free to update the API docs!

No worries, thank you!

@renao renao deleted the fix/isfinal-type branch February 5, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants