home‐assistant Reconnect

bug.mp4

build MinimalDebug

Bug in https://github.com/home-assistant/android/blob/2373127fb0ff1be447e4138ae1f2c85aad2645c8/app/src/main/java/io/homeassistant/companion/android/webview/WebViewActivity.kt#L1358

alert.setMessage(commonR.string.webview_error)
alert.setPositiveButton(commonR.string.settings) { _, _ ->
    startActivity(SettingsActivity.newInstance(this))
    // NO webView.loadUrl()
}
val isInternal = serverManager.getServer(presenter.getActiveServer())?.connection?.isInternal() == true
alert.setNegativeButton(
    if (failedConnection == "external" && isInternal) {
        commonR.string.refresh_internal
    } else {
        commonR.string.refresh_external
    }
) { _, _ ->
    runBlocking {
        failedConnection = if (failedConnection == "external") {
            serverManager.getServer(presenter.getActiveServer())?.let { webView.loadUrl(it.connection.getUrl(true).toString()) }
            "internal"
        } else {
            serverManager.getServer(presenter.getActiveServer())?.let { webView.loadUrl(it.connection.getUrl(false).toString()) }
            "external"
        }
        // webView.loadUrl() reloads the page!
    }
    waitForConnection() // FAKE! Only checks variables...
}
alert.setNeutralButton(commonR.string.wait) { _, _ ->
    waitForConnection() // FAKE! Only checks variables...
    // NO webView.loadUrl()
}