Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 11, 2025

Important

Add pr-reviewer mode with workflow, best practices, and common mistakes for PR review.

  • New Mode:
    • Adds pr-reviewer mode in .roomodes for reviewing pull requests with a focus on code quality, structure, and i18n.
  • Workflow:
    • Adds 1_workflow.xml with steps for fetching PR info, diff, checking out locally, reviewing, and submitting comments.
  • Best Practices:
    • Adds 2_best_practices.xml outlining guidelines for effective PR review.
  • Common Mistakes:
    • Adds 3_common_mistakes_to_avoid.xml listing errors to avoid during PR review.

This description was created by Ellipsis for d1aedc5. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 11, 2025 00:12
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 11, 2025
@daniel-lxs daniel-lxs marked this pull request as draft June 11, 2025 00:12
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 11, 2025
@daniel-lxs daniel-lxs moved this from PR [Draft / In Progress] to PR [Needs Review] in Roo Code Roadmap Jun 11, 2025
@daniel-lxs daniel-lxs marked this pull request as ready for review June 11, 2025 20:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 11, 2025
@mrubens mrubens merged commit bf14b37 into main Jun 11, 2025
30 checks passed
@mrubens mrubens deleted the pr-reviewer branch June 11, 2025 21:27
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 11, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants