-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Edit/Delete with Checkpoints #5710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future consideration: The state transitions during checkpoint restoration (task running → aborting → restoring → reinitialized → processing pending edits) could benefit from a formal state machine implementation to make the flow more explicit.
LGTM.
|
There's a lot in this PR. Do you think we could break it down into smaller independent pieces, like for instance a PR to change when we do the checkpoint first? And then follow it up by using checkpoints for edit/delete? |
|
@mrubens #6359 has been merged. I believe this pull request contains significant changes. Currently, checkpoints can restore both tasks and files. However, checkpoint triggering is currently more file-dependent. Furthermore, checkpoints are currently guaranteed to be created before modifications are made. A more requested feature is #2943. |
|
Hey @NaccOll We are aware of the changes to checkpoints done by this PR, we are working on a version of this PR that doesn't the checkpoint logic but achieves the same result |
|
I will resolve conflicts based on this PR code, and adapting the new checkpoint generation timing (#6359), and finally complete the "Enhanced User Message Deletion Dialog" and "User Message Edit Functionality" mentioned in #7285. Although this is a content that has already been completed by this PR. |
We now make a checkpoint after every user message so when a user edits a user message. Now when a user has checkpoints enabled, upon deleting or editing a message they are asked if they would like to restore the checkpoint right before the message was sent
Feature Loom: https://www.loom.com/share/a810f38550524e079c3d8c6eb8c53ce5
Edge cases + stress testing Loom: https://www.loom.com/share/28e56e97da944cc18144b9c92594b8e5
Follow Up question editing Loom: https://www.loom.com/share/8f6da376cbb842219ba4eb9aa7956b04
Checkpoints not enabled Loom: https://www.loom.com/share/0fdfde900c494239a16ac19ad26a597f
Fixes #4703
Important
Adds checkpoint restoration feature for message edits and deletions with user confirmation dialogs and updates translations.
App.tsx,ChatRow.tsx, andChatView.tsx.CheckpointRestoreDialogcomponent to handle user confirmation for restoring checkpoints.ChatRow.tsxto include edit and delete buttons that trigger checkpoint dialogs.ChatView.tsxto manage dialog state and handle user interactions for checkpoint restoration.CheckpointRestoreDialog.spec.tsxto test dialog behavior and user interactions.This description was created by
for 85268aa. You can customize this summary. It will automatically update as commits are pushed.