Skip to content

Conversation

@CellenLee
Copy link

@CellenLee CellenLee commented Sep 4, 2025

Related GitHub Issue

Closes: #

Roo Code Task Context (Optional)

Description

update kimi-k2-0905-preview and kimi-k2-turbo-preview

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Update moonshotDefaultModelId and add kimi-k2-0905-preview with updated context window and pricing.

  • Behavior:
    • Update moonshotDefaultModelId to kimi-k2-0905-preview in moonshot.ts.
    • Add new model kimi-k2-0905-preview with contextWindow 262,144 and pricing details.
    • Update contextWindow for kimi-k2-turbo-preview to 262,144.

This description was created by Ellipsis for 7c13a94. You can customize this summary. It will automatically update as commits are pushed.

@CellenLee CellenLee requested review from cte, jr and mrubens as code owners September 4, 2025 07:39
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 4, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged.

export type MoonshotModelId = keyof typeof moonshotModels

export const moonshotDefaultModelId: MoonshotModelId = "kimi-k2-0711-preview"
export const moonshotDefaultModelId: MoonshotModelId = "kimi-k2-0905-preview"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new kimi-k2-0905-preview model already available in production? Changing the default model could break functionality for users if this model isn't accessible yet. Have you verified its availability?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
"kimi-k2-0905-preview": {
maxTokens: 32_000,
contextWindow: 262_144,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context window has been doubled from 131,072 to 262,144 tokens. Has this been tested with large contexts? This significant increase could impact:

  • Memory usage and performance
  • API rate limits
  • Cost calculations for users

outputPrice: 2.5, // $2.50 per million tokens
cacheWritesPrice: 0, // $0 per million tokens (cache miss)
cacheReadsPrice: 0.15, // $0.15 per million tokens (cache hit)
description: `Kimi K2 is a state-of-the-art mixture-of-experts (MoE) language model with 32 billion activated parameters and 1 trillion total parameters.`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is identical to the older kimi-k2-0711-preview model. If this is a newer version with improvements, could we update the description to reflect what's new or different about the 0905 version?

"kimi-k2-turbo-preview": {
maxTokens: 32_000,
contextWindow: 131_072,
contextWindow: 262_144,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar concern here - the context window for kimi-k2-turbo-preview has been doubled. Has this change been tested for performance impact, especially given this is the 'turbo' variant optimized for speed?

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 4, 2025
@daniel-lxs
Copy link
Member

The context widnow doesn't seem to match the official docs: https://platform.moonshot.ai/docs/introduction

Am I missing something?

@daniel-lxs daniel-lxs moved this from Triage to PR [Changes Requested] in Roo Code Roadmap Sep 4, 2025
@hannesrudolph hannesrudolph added PR - Changes Requested and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 4, 2025
@mrubens
Copy link
Collaborator

mrubens commented Sep 5, 2025

@mrubens
Copy link
Collaborator

mrubens commented Sep 5, 2025

Test is failing, but I can fix it in main.

@mrubens mrubens merged commit d9f80f1 into RooCodeInc:main Sep 5, 2025
26 of 30 checks passed
@github-project-automation github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Sep 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Changes Requested size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants