Skip to content

Conversation

@brunobergher
Copy link
Collaborator

@brunobergher brunobergher commented Sep 15, 2025

As it says on the tin, makes the default state cleaner.
No functional changes.


Important

Buttons in ChatTextArea now only appear when there is text input, using a memoized check to conditionally apply styles.

  • Behavior:
    • Buttons in ChatTextArea only appear when there is text input, using hasInputContent to check input content.
    • Buttons have opacity-0 and pointer-events-none when no text, and opacity-50 or opacity-100 with pointer-events-auto when text is present.
  • Code Changes:
    • Added hasInputContent memoized check in ChatTextArea.tsx to determine if input has content.
    • Updated button styles in ChatTextArea.tsx to conditionally apply styles based on hasInputContent.

This description was created by Ellipsis for f8e0072. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and the implementation successfully achieves the goal of making the UI cleaner by hiding buttons when there's no text. I have some suggestions for improvement below.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 15, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Let me know when it's ready to merge.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 15, 2025
@brunobergher brunobergher marked this pull request as ready for review September 15, 2025 14:55
@brunobergher brunobergher requested review from cte and jr as code owners September 15, 2025 14:55
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Sep 15, 2025
@mrubens mrubens merged commit 9d33c10 into main Sep 15, 2025
34 of 37 checks passed
@mrubens mrubens deleted the bb/ux/cleaner-chat-area branch September 15, 2025 15:01
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 15, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants