Skip to content

Conversation

@snova-jorgep
Copy link

@snova-jorgep snova-jorgep commented Sep 19, 2025

Related GitHub Issue

#8185

Closes: #

Description

update list of models available in sambanova provider, adding deepseekv3.1 and gpt oss 120b

Test Procedure

open the sambanova model list dropdown

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

jorgepiedrahita_58208


Important

Add DeepSeek-V3.1 and gpt-oss-120b models to SambaNova provider in sambanova.ts.

  • Models Update:
    • Add DeepSeek-V3.1 and gpt-oss-120b to SambaNovaModelId in sambanova.ts.
    • Update sambaNovaModels in sambanova.ts with properties for DeepSeek-V3.1 and gpt-oss-120b, including maxTokens, contextWindow, supportsImages, supportsPromptCache, inputPrice, outputPrice, and description.

This description was created by Ellipsis for de032d8. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Sep 19, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and found a critical issue that needs attention along with some suggestions for improvement.

},
"gpt-oss-120b": {
maxTokens: 8192,
contextWindow: 8192,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Issue: There's an inconsistency here - the description states "128k context window" but the contextWindow property is set to 8192 (8K). Could you verify which value is correct and update accordingly?

If the context window is indeed 128K, it should be 131072 (128 * 1024).

| "Llama-4-Maverick-17B-128E-Instruct"
| "Llama-3.3-Swallow-70B-Instruct-v0.4"
| "Qwen3-32B"
| "gpt-oss-120b"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is gpt-oss-120b the official model name from SambaNova? The naming pattern differs from other models which use proper casing (e.g., "DeepSeek-V3.1"). Should this perhaps be "GPT-OSS-120B" for consistency with the naming convention used by other models?

@roomote
Copy link

roomote bot commented Sep 19, 2025

Additionally, here are some other suggestions to consider:

  1. Test Coverage: Consider adding test cases for the newly added models (DeepSeek-V3.1 and gpt-oss-120b) in src/api/providers/__tests__/sambanova.spec.ts to ensure they're properly configured and accessible.

  2. Documentation Verification: It would be helpful to verify that the model specifications (pricing, context windows, max tokens) match SambaNova's official documentation at https://docs.sambanova.ai/cloud/docs/get-started/supported-models

  3. PR Description: To properly link and auto-close the issue when merged, consider updating the "Closes: #" field in the PR description to reference issue [BUG] outdated sambanova model list  #8185.

These are non-blocking suggestions, but addressing them would improve the overall quality of the PR.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 19, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Sep 19, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Sep 19, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @snova-jorgep !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 19, 2025
@mrubens mrubens merged commit d6cb396 into RooCodeInc:main Sep 20, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Sep 20, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants