Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Sep 29, 2025

Summary:

  • Correct Anthropic model id to official claude-sonnet-4-5 (resolves 404)
  • Add single shared list for Bedrock models supporting 1M context (includes Sonnet 4 and 4.5)
  • Show 1M context checkbox for Sonnet 4.5 in Bedrock settings

Key changes:

  • packages/types/src/providers/anthropic.ts
  • src/api/providers/anthropic.ts
  • packages/types/src/providers/claude-code.ts
  • packages/types/src/providers/bedrock.ts
  • webview-ui/src/components/settings/providers/Anthropic.tsx
  • webview-ui/src/components/settings/providers/Bedrock.tsx
  • webview-ui/src/components/ui/hooks/useSelectedModel.ts
  • src/api/providers/tests/anthropic.spec.ts

Validation:

  • cd src && npx vitest run api/providers/tests/anthropic.spec.ts → passing
  • cd src && npx vitest run api/providers/tests/bedrock.spec.ts → passing
  • cd packages/types && npx tsc --noEmit → OK
  • cd webview-ui && npx tsc --noEmit → OK

Notes:

  • Vertex mapping remains unchanged (different id scheme).

Important

Fix Anthropic model ID to claude-sonnet-4-5 and add 1M context support for Bedrock models.

  • Behavior:
    • Correct Anthropic model ID to claude-sonnet-4-5 in anthropic.ts, claude-code.ts, and anthropic.spec.ts.
    • Add BEDROCK_1M_CONTEXT_MODEL_IDS list in bedrock.ts for models supporting 1M context.
    • Show 1M context checkbox for Sonnet 4.5 in Anthropic.tsx and Bedrock.tsx.
  • Validation:
    • Tests in anthropic.spec.ts updated to use claude-sonnet-4-5 and validate 1M context behavior.
    • TypeScript checks in packages/types and webview-ui pass without errors.
  • Misc:
    • No changes to Vertex mapping as it uses a different ID scheme.

This description was created by Ellipsis for d4815f2. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Sep 29, 2025
fix(bedrock): enable 1M context checkbox for Sonnet 4.5 via shared list
closes #8379
closes #8381
@daniel-lxs daniel-lxs force-pushed the fix/anthropic-sonnet-4-5-and-bedrock-1m branch from 4ab45be to d4815f2 Compare September 29, 2025 21:39
@@ -458,3 +458,7 @@ export const BEDROCK_REGIONS = [
].sort((a, b) => a.value.localeCompare(b.value))

export const BEDROCK_CLAUDE_SONNET_4_MODEL_ID = "anthropic.claude-sonnet-4-20250514-v1:0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 29, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 29, 2025
@mrubens mrubens merged commit b264495 into main Sep 29, 2025
14 of 15 checks passed
@mrubens mrubens deleted the fix/anthropic-sonnet-4-5-and-bedrock-1m branch September 29, 2025 21:49
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Sep 29, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Sep 29, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants