Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Oct 9, 2025

Reverts #8495


Important

Reverts clamping of GPT-5 model max output tokens to 20% of context window, allowing full configured max tokens instead.

  • Behavior:
    • Reverts clamping of GPT-5 model max output tokens to 20% of context window in getModelMaxOutputTokens() in api.ts.
    • GPT-5 models now use their full configured max tokens, bypassing the 20% cap.
  • Tests:
    • Update api.spec.ts to reflect the removal of the 20% cap for GPT-5 models.
    • Tests for various GPT-5 model IDs to ensure full max tokens are used.
    • Non-GPT-5 models still tested for 20% cap enforcement.

This description was created by Ellipsis for 87700ba. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners October 9, 2025 16:55
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 9, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new issues found. The revert is clean and complete - all tests pass and the changes correctly restore the 20% cap for GPT-5 models.

@mrubens mrubens merged commit 507a600 into main Oct 9, 2025
13 of 14 checks passed
@mrubens mrubens deleted the revert-8495-feat/limit-gpt5-max-output-20pct branch October 9, 2025 17:00
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Oct 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Oct 9, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants