Fix SEGV in transcribe_type when compiling libcore 1.29 #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
reviewed
Aug 30, 2022
gcc/rust/ast/rust-ast.h
Outdated
| */ | ||
|
|
||
| bool is_single_fragment () const { return nodes.size () == 1; } | ||
| bool is_single_fragment (SingleASTNode::NodeType expected) const |
Member
There was a problem hiding this comment.
Not sure about the name of this method. Its a pet nit of mine that I prefer to use overloading only on methods where they already take arguments. It feels like a new method to check if is_single_fragment and that single fragment is of a particular type.
How about is_single_fragment_of_kind (...)
Member
Author
There was a problem hiding this comment.
Ah, I see what you mean. I'll rename it. assert_single_fragment kinda serves the same purpose but it also crashes if the assertion fails, so it's a bit different from is_single_fragment
philberty
reviewed
Aug 30, 2022
| } | ||
|
|
||
| bool is_single_fragment_kind (SingleASTNode::NodeType kind) const | ||
| void assert_single_fragment (SingleASTNode::NodeType expected) const |
Member
There was a problem hiding this comment.
ah ok so it gets renamed here anyway :)
CohenArthur
force-pushed
the
segv-transcribe-type-1.29
branch
from
3564cef to
4423754
Compare
CohenArthur
force-pushed
the
segv-transcribe-type-1.29
branch
from
4423754 to
21cfed5
Compare
Member
Author
|
bors r+ |
Contributor
|
Merge conflict. |
CohenArthur
force-pushed
the
segv-transcribe-type-1.29
branch
from
21cfed5 to
fcf6fea
Compare
Member
Author
|
bors retry |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #1513, Skip reviewing the first commit