Fix narrowing of Loan (size_t) into LoanId (uint32) #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkm
force-pushed
the
dkm/fix_narrowing_error
branch
3 times, most recently
from
6387a1d to
e9dd6f5
Compare
Fix narrowing:
-../../gcc/rust/checks/errors/borrowck/rust-borrow-checker-diagnostics.cc:145:46:
warning: narrowing conversion of ‘loan’ from ‘Rust::Polonius::Loan’ {aka
‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned int’} [-Wnarrowing]
gcc/rust/ChangeLog:
* checks/errors/borrowck/rust-bir-place.h (LoanId::value): Make
it size_t to match Loan's base type.
Signed-off-by: Marc Poulhiès <[email protected]>
After previous change, removed the last warning from the expected file. ChangeLog: * .github/glibcxx_ubuntu64b_log_expected_warnings: Remove warning. * .github/log_expected_warnings: Likewise. Signed-off-by: Marc Poulhiès <[email protected]>
dkm
force-pushed
the
dkm/fix_narrowing_error
branch
from
e9dd6f5 to
0bd440e
Compare
|
I don't understand why the warning is not present in the #3860 branch, but I think it makes sense to have both types be the same size. |
Open
philberty
approved these changes
Jul 10, 2025
|
Hmm, shouldn't this instead have merged the GCC upstream commit 1e69c56 "rust: Silence a clang warning in borrow-checker-diagnostics"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix narrowing: