gccrs: add error check if derive has wrong item #4211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasly-ba
force-pushed
the
3972
branch
3 times, most recently
from
f9b39d2 to
ee28811
Compare
CohenArthur
reviewed
Oct 15, 2025
Comment on lines
184
to
192
| if (item.get_item_kind () != AST::Item::Kind::Enum | ||
| && item.get_item_kind () != AST::Item::Kind::Struct | ||
| && item.get_item_kind () != AST::Item::Kind::Union) | ||
| { | ||
| rust_error_at (current.get_locus (), | ||
| "derive may only be applied to structs, " | ||
| "enums and unions"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I would put that check in DeriveVisitor::derive instead:
gccrs/gcc/rust/expand/rust-derive.cc
Line 37 in b92a684
The ExpandVisitor is already a massive visitor, so I would rather we move specific checks to more specific visitors.
The code itself is great - maybe just create a temporary variable so it's not as long:
auto item_kind = item.get_item_kind();
if (item_kind != AST::Item::Kind::Struct && item_kind != ...)
rust_error_at(...);
lucasly-ba
force-pushed
the
3972
branch
4 times, most recently
from
bdc4c1b to
c246504
Compare
Derive may only be applied to structs, enums and unions. gcc/rust/ChangeLog: * expand/rust-derive.cc (DeriveVisitor::derive): Add check and error. gcc/testsuite/ChangeLog: * rust/compile/issue-3971.rs: New test. gcc/rust/ChangeLog: * expand/rust-derive.cc (DeriveVisitor::derive): * expand/rust-expand-visitor.cc: gcc/testsuite/ChangeLog: * rust/compile/issue-3971.rs: New test. Signed-off-by: Lucas Ly Ba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive may only be applied to structs, enums and unions.
Fixes #3971
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
Signed-off-by: Lucas Ly Ba [email protected]