Update to changes in BatchNormalize
#1248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
non-identity-batch-normalize
branch
5 times, most recently
from
0ecb825 to
b6d5ba0
Compare
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Jun 13, 2025
As discussed in #1889. I will add some tests in `elliptic-curves` as well. Resolves #1889. Companion PR: RustCrypto/elliptic-curves#1248.
daxpedda
force-pushed
the
non-identity-batch-normalize
branch
from
b6d5ba0 to
02f488f
Compare
Merged
|
Closing in favor of #1257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to changes made in
BatchNormalizein RustCrypto/traits#1896. I also added a test forNonIdentity::batch_normalizeforp256.I looked into moving this test into
test_projective_arithmetic, but I don't see a good way to currently do this because of how we can't get that array type forprop_compose. Alternatively we could require the corresponding types to implementStrategy.proptestalso just updated torandv0.9 so I think this would be a good idea. WDYT?Depends on RustCrypto/traits#1896.