Skip to content

Implement GroupDigest for NistP256 and Secp256k1 #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 15, 2022
Merged

Implement GroupDigest for NistP256 and Secp256k1 #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4190ffc
Implement `GroupDigest` for `NistP256`
daxpedda Jan 7, 2022
fc57e70
Implement `GroupDigest` for `Secp256k1`
daxpedda Jan 7, 2022
16b619d
Update to newest version
daxpedda Jan 8, 2022
850bde2
Update to newest version
daxpedda Jan 8, 2022
ec3d645
Clean up k256 OSSWU implementation
daxpedda Jan 8, 2022
deb6ecb
Use more efficient implementation for `FromOkm` for `Scalar`
daxpedda Jan 8, 2022
c685bee
Make conversions cross-platform
daxpedda Jan 8, 2022
0ce8f72
Fuzz `from_okm`
daxpedda Jan 8, 2022
fb4da57
Update to elliptic-curve 0.11.7
daxpedda Jan 14, 2022
67efaaf
Add `hash2curve` to CI
daxpedda Jan 14, 2022
311ff1e
Fix rebase
daxpedda Jan 14, 2022
387b182
Remove `sgn0` method
daxpedda Jan 14, 2022
adc821c
Move `normalize()` into `is_odd()`
daxpedda Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/k256.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdh
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa-core
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features hash2curve
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features jwk
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features keccak256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features pem
Expand All @@ -49,7 +50,7 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features sha256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa,keccak256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa,sha256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features arithmetic,bits,ecdh,ecdsa,jwk,keccak256,pem,pkcs8,serde,sha256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features arithmetic,bits,ecdh,ecdsa,hash2curve,jwk,keccak256,pem,pkcs8,serde,sha256

benches:
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/p256.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdh
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa-core
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features ecdsa
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features hash2curve
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features jwk
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features pem
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features pkcs8
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features serde
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features sha256
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features voprf
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features arithmetic,bits,ecdh,ecdsa,jwk,pem,pkcs8,serde,sha256,voprf
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features arithmetic,bits,ecdh,ecdsa,hash2curve,jwk,pem,pkcs8,serde,sha256,voprf

test:
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion k256/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ rust-version = "1.56"

[dependencies]
cfg-if = "1.0"
elliptic-curve = { version = "0.11.6", default-features = false, features = ["hazmat", "sec1"] }
elliptic-curve = { version = "0.11.7", default-features = false, features = ["hazmat", "sec1"] }
sec1 = { version = "0.2", default-features = false }

# optional dependencies
Expand All @@ -46,6 +46,7 @@ digest = ["ecdsa-core/digest", "ecdsa-core/hazmat"]
ecdh = ["arithmetic", "elliptic-curve/ecdh"]
ecdsa = ["arithmetic", "digest", "ecdsa-core/sign", "ecdsa-core/verify"]
expose-field = ["arithmetic"]
hash2curve = ["elliptic-curve/hash2curve"]
jwk = ["elliptic-curve/jwk"]
keccak256 = ["digest", "sha3"]
pem = ["elliptic-curve/pem", "ecdsa-core/pem", "pkcs8"]
Expand Down
2 changes: 2 additions & 0 deletions k256/src/arithmetic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

pub(crate) mod affine;
mod field;
#[cfg(feature = "hash2curve")]
mod hash2curve;
mod mul;
pub(crate) mod projective;
pub(crate) mod scalar;
Expand Down
2 changes: 1 addition & 1 deletion k256/src/arithmetic/affine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ impl DecompressPoint<Secp256k1> for AffinePoint {
let y = FieldElement::conditional_select(
&beta.negate(1),
&beta,
beta.normalize().is_odd().ct_eq(&y_is_odd),
beta.is_odd().ct_eq(&y_is_odd),
);

Self {
Expand Down
3 changes: 1 addition & 2 deletions k256/src/arithmetic/field/field_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@ impl FieldElementImpl {
}

pub fn is_odd(&self) -> Choice {
debug_assert!(self.normalized);
self.value.is_odd()
self.normalize().value.is_odd()
}

pub fn negate(&self, magnitude: u32) -> Self {
Expand Down
Loading