Implement capstone gmi functions #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement gmi_closest_point implement gmi_is_point_in_region implement gmi_is_in_closure_of Signed-off-by: Aiden Woodruff <[email protected]>
- We decided that it is ok to use the inefficient get_closest_point_param call without seedparam for general calls. Signed-off-by: Aiden Woodruff <[email protected]>
Signed-off-by: Aiden Woodruff <[email protected]>
- Test a few points on a square face and edge. Signed-off-by: Aiden Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement capstone gmi functions
The functions
gmi_closest_point,gmi_is_point_in_region, andgmi_is_in_closure_ofare implemented in terms of Capstone functions.TODO:
[ ] gmi_closest_point needs seedparam.We decided the inefficiency is ok.