Clarify that orthogonal basis frames are columns #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bobpaw
commented
Oct 7, 2024
bobpaw
commented
- Although apf::Matrix stores rows of vectors, MeshAdapt expects basis frames on columns (as indicated by ma/maSize.cc:97). This was not made clear anywhere else. I wasted time not realizing it, so I added it explicitly in header documentation instead of buried in source code.
- Although apf::Matrix stores rows of vectors, MeshAdapt expects basis frames on columns (as indicated by ma/maSize.cc:97). This was not made clear anywhere else. I wasted time not realizing it, so I added it explicitly. Signed-off-by: Aiden Woodruff <[email protected]>
Closed
flagdanger
pushed a commit
to jacobmerson/core
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.