added google maps link #114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Já tem um PR com essa funcionalidade: #103 |
Vi que tem na tela de detalhes do abrigo, adicionei o link da página inicial |
antoniolucasnobar
approved these changes
May 13, 2024
| [capacity, shelteredPeople] | ||
| ); | ||
| const address = encodeURIComponent(data.address); | ||
| const googleMapsUrl = `https://www.google.com/maps/search/?api=1&query=${address}`; |
There was a problem hiding this comment.
@La-Rocca ja que temos a latitude e a longitude, não seria mais preciso utilizar eles ao invés da busca pelo endereço?
There was a problem hiding this comment.
No #103 me responderam que a UX nao fica tao boa com a latitude e longitude, ja que nao exibe o nome do lugar, contato, etc...
There was a problem hiding this comment.
No arquivo de teste do banco, os dados de latitude e longitude estavam vindo nulos, por isso resolvi não usa-los.
avulso17
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adicionado link para o google maps, assim fica mais fácil identificar o local do abrigo.