Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Add Node 12 #8

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Add Node 12 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{ "tag": "6", "from": "node:6" },
{ "tag": "6-npm6.1", "from": "node:6", "extraInstructions": ["RUN npm install [email protected]", "RUN rm -rf /usr/local/lib/node_modules/npm", "RUN mv node_modules/npm /usr/local/lib/node_modules/npm"] },
{ "tag": "8", "from": "node:8" },
{ "tag": "10", "from": "node:10" }
{ "tag": "10", "from": "node:10" },
{ "tag": "12", "from": "node:12" }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the explicit tag, could we just do a {"tag": "12.13.0", "from": "node:12.13.0"}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would work, I just didn't know if that was something we wanted to do. Obviously, minor/patch versions come out more frequently than major ones, so we'd have to add new ones more often in order to stay up-to-date. I don't know how annoying it would be for people if I made a new "add 12.x.y" image every time they released a new one.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd have to do every one, just the ones we felt were necessary. It's not like the major version ones get updated all the time anyways.

]
}
8 changes: 8 additions & 0 deletions out/Dockerfile.12
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
FROM node:12
ENV NPM_CONFIG_LOGLEVEL warn

WORKDIR /opt/cs-service/

EXPOSE 40404

CMD ["npm", "start"]