-
Notifications
You must be signed in to change notification settings - Fork 83
Remove uncontrolled input support #7458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
damienrobson-sage
wants to merge
21
commits into
master
Choose a base branch
from
FE-5305-remove-uncontrolled-input-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove uncontrolled input support #7458
damienrobson-sage
wants to merge
21
commits into
master
from
FE-5305-remove-uncontrolled-input-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c55695
to
3b4313b
Compare
c53511b
to
d7a32d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: all input-based components must now be used in a controlled manner e.g.:
Component props designed to support uncontrolled usage e.g.
defaultValue
have been removed, and allvalue
andonChange
props are now requiredProposed behaviour
Remove support for uncontrolled usage from the following components:
Current behaviour
Our input-based components support uncontrolled usage
Checklist
d.ts
file added or updated if requiredQA