Skip to content

[Compute] Autogen PR Issue 4 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Compute] Autogen PR Issue 4 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Compute/Compute/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@

-->
## Upcoming Release
* Enhanced `Set-AzDiskSecurityProfile` cmdlet with new parameter `SecureVMDiskEncryptionSetId`.
- Added logic to verify `SecureVMDiskEncryptionSetId` is a resourceId.
- Added logic to verify `SecureVMDiskEncryptionSetId` is a string.
- Added logic to set all characters of `SecureVMDiskEncryptionSetId` to lower case.
* Fixed `New-AzVmss` to correctly work when using `-EdgeZone` by creating the Load Balancer in the correct edge zone.
* Removed references to image aliases in `New-AzVM` and `New-AzVmss` to images that were removed.
* Fixed `New-AzVmss` to correctly work when using `-EdgeZone` by creating the Load Balancer in the correct edge zone.
* Removed references to image aliases in `New-AzVM` and `New-AzVmss` to images that were removed.

Expand Down
11 changes: 6 additions & 5 deletions src/Compute/Compute/Generated/Disk/Config/SetAzDiskSecurityProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ----------------------------------------------------------------------------------
// ----------------------------------------------------------------------------------
//
// Copyright Microsoft Corporation
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -52,7 +52,7 @@ public class SetAzDiskSecurityProfile : Microsoft.Azure.Commands.ResourceManager
Mandatory = false,
ValueFromPipelineByPropertyName = true,
HelpMessage = "ResourceId of the disk encryption set to use for enabling encryption at rest.")]
public string SecureVMDiskEncryptionSet { get; set; }
public string SecureVMDiskEncryptionSetId { get; set; }

protected override void ProcessRecord()
{
Expand Down Expand Up @@ -85,17 +85,18 @@ private void Run()
this.Disk.SecurityProfile.SecurityType = SecurityType;
}

if (this.IsParameterBound(c => c.SecureVMDiskEncryptionSet))
if (this.IsParameterBound(c => c.SecureVMDiskEncryptionSetId))
{
if (this.Disk.SecurityProfile == null)
{
this.Disk.SecurityProfile = new DiskSecurityProfile();
}
this.Disk.SecurityProfile.SecureVMDiskEncryptionSetId = this.SecureVMDiskEncryptionSet;
this.Disk.SecurityProfile.SecureVMDiskEncryptionSetId = this.SecureVMDiskEncryptionSetId.ToLower();
}

WriteObject(this.Disk);
}
}

}
}

3 changes: 2 additions & 1 deletion src/Compute/Compute/Generated/Models/PSDisk.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//
//
// Copyright (c) Microsoft and contributors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -81,3 +81,4 @@ public string ResourceGroupName
public bool? OptimizedForFrequentAttach { get; set; }
}
}
.