Save dts and sol.stats into WorkPrecision
#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that while this works very well with ODEProblems and my own tests, it's a bit messy for ensemble problems and RODEs. I could go ahead and fix things, but I'll first wait for some feedback to make sure this is actually a desired change. |
|
Locally the tests pass; and the formatting is off on the master branch already, so I didn't change it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When benchmarking fixed-step solvers, plotting the step size or the number of function evaluations is often the desired result. And having quantities accessible such as the number of accepted and rejected steps, created Jacobians, etc, might also enable some more fancy evaluations. Saving
dtsandsol.statsinto theWorkPrecisionobject would make this possible.