-
-
Notifications
You must be signed in to change notification settings - Fork 6
Update to MTK@v10 and simplify connectors #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jul 8, 2025
|
Thanks, @ChrisRackauckas |
We can simplify the NeuralNetworkBlock a bit by using normal vector variables instead of RealInput/OutputArrays.
f35c834 to
347c0e6
Compare
|
This should be ready now, tests on release and lts pass and the docs build. I want to do a larger documentation rewrite, but that's a separate PR. The formatting and invalidations tests might be broken, the formatter is happy locally. |
This was referenced Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I've taken the opportunity to use this breaking change in MTK to also have a breaking change here and get rid of the MTKStdLib dependency. This should allow people to use the
SymbolicNeuralNetworkinterface without that extra dependency and we didn't really need theRealInput/OutputArrayblocks. The interface ended up being a bit awkward and when the block interacts with the rest of the model you will most likely want to use it across several equations, so the input/output blocks don't bring any advantage, it mostly make the code more complex.As such, I changed the inputs and outputs to normal vector variables and we can now also
connectthem toRealInput/OutputArrayblocks if we use the inner.us.