Skip to content

Conversation

@SebastianM-C
Copy link
Member

@SebastianM-C SebastianM-C commented Jul 8, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I've taken the opportunity to use this breaking change in MTK to also have a breaking change here and get rid of the MTKStdLib dependency. This should allow people to use the SymbolicNeuralNetwork interface without that extra dependency and we didn't really need the RealInput/OutputArray blocks. The interface ended up being a bit awkward and when the block interacts with the rest of the model you will most likely want to use it across several equations, so the input/output blocks don't bring any advantage, it mostly make the code more complex.

As such, I changed the inputs and outputs to normal vector variables and we can now also connect them to RealInput/OutputArray blocks if we use the inner .us.

@SebastianM-C SebastianM-C mentioned this pull request Jul 8, 2025
5 tasks
@SebastianM-C
Copy link
Member Author

SebastianM-C commented Jul 8, 2025

Thanks, @ChrisRackauckas
I still need to do the docs update, but the package code should be ready (hence the draft status).

We can simplify the NeuralNetworkBlock a bit by using normal vector
variables instead of RealInput/OutputArrays.
@SebastianM-C SebastianM-C force-pushed the smc/update branch 3 times, most recently from f35c834 to 347c0e6 Compare July 9, 2025 00:57
@SebastianM-C SebastianM-C marked this pull request as ready for review July 9, 2025 18:24
@SebastianM-C
Copy link
Member Author

This should be ready now, tests on release and lts pass and the docs build. I want to do a larger documentation rewrite, but that's a separate PR.

The formatting and invalidations tests might be broken, the formatter is happy locally.

@SebastianM-C SebastianM-C merged commit 7f9a153 into main Jul 9, 2025
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants