Ensure globals are looked up in the user's module #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create method of `generated_callfunc` in the user's module so that any global symbols within the body will be looked up in the user's module scope. This is straightforward but clunky. A neater solution should be to explicitly expand in the user's module and return a CodeInfo from `generated_callfunc`, but it seems we'd need `jl_expand_and_resolve` which doesn't exist until Julia 1.3 or so. See: * JuliaLang/julia#32902 * https://github.com/NHDaly/StagedFunctions.jl/blob/master/src/StagedFunctions.jl#L30
The syntax RuntimeGeneratedFunctions.init(user_mod) is less cute but more general way to name the initialization function. (The need to initialize data structures in user modules isn't entirely unique to RuntimeGeneratedFunctions.)
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 92.10% 90.00% -2.11%
==========================================
Files 1 1
Lines 38 40 +2
==========================================
+ Hits 35 36 +1
- Misses 3 4 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create method of
generated_callfuncin the user's module so that any global symbols within the body will be looked up in the user's module scope.This is straightforward but a bit clunky. A neater solution might be to explicitly expand in the user's module and return a CodeInfo from
generated_callfunc, but it seems we'd needjl_expand_and_resolvewhich doesn't exist until Julia 1.3 or so. See: