Throw an Error if level is ErrorLevel, add Logging.Debug
as a Level
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
First, this makes it so that if the
level
is anErrorLevel
,emit_message
will also throw an exception, after putting theError
message in to the log.To be clear this means that
will put an error message in to the log, then throw an
ErrorException
, ifverbose.setting
is anErrorLevel
.@ChrisRackauckas is that the desired behavior? I could also make it so that
ErrorLevel
has a Bool field, so users can choose to just send the message to the log and not throw an error.Second, Logging.Debug is a thing, so it should be exposed and able to be used.
Also cleaned up the signature for
emit_message
, got rid of now unneeded arguments.