- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 22
WIP: use Groebner.jl instead of Singular.jl/GroebnerBasis.jl #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @sumiya11 , thanks for the summary! Saturation is currently done by simply adding a new variable, and we can proceed this way. Of course dedicated algorithm would be cool. | 
| @pogudingleb do you think we can just check cancellation property for all residuals? | 
| 
 Do you mean checking directly whether there are zero divisors? I am a bit sceptical about this. What I thought that one could maybe compute the quotient ring easier thanks to the special form of the polynomials. | 
| Yep, exactly. Probably checking O(n^2) normal forms over finite field of random characteristic with existing f4 should not be slower than a basis computation itself. | 
| Yes, I would expect  | 
| I do actually! | 
| I would go even further an say that I do not really need  | 
| @pogudingleb We use a non-sparse fglm very similar to the one described here. We don't have multiplication matrices (yet) =( | 
| is this still WIP? I encounter the same issue with the package not precompiling due to Singular.jl and GroebnerBasis.jl. Thanks!  | 
| Hi @fkrauer , Yes, the work is ongoing ! I still need to get JuliaLang/julia#44566 merged and implement quotient space interface | 
| @sumiya11 Let me know if you need any help | 
| Hi, @fkrauer, this is a known compatibility issue for Windows (e.g. #70). Meanwhile, we have a Maple web-interface for quick and comprehensive identifiability analysis. I hope this helps! | 
| 
 Looks awesome, thanks. I am trying it out now. I hope I didn't break the interface, the model is quite large :/ | 
| 
 @fkrauer, if the model does finish, feel free to send it to me. We like challenging models. | 
| uh sorry there was a typo in the model equations and I reloaded too many times I think 🙈 apologies! I might have crashed the application. | 
| Yaay, finally  | 
| Cool! | 
| Hi! All needed functions are finally implemented. @pogudingleb and I are now testing performance with Groebner.jl vs. Singular ⏳ | 
| Hi @sumiya11, I tried to run some experiments locally with this code, but I got an error saying Will this PR remove Singular.jl from dependencies? | 
| @iliailmer | 
| @fkrauer | 
Hi! It would be nice to escape from a deprecated package, and use windows-compatible groebner bases. For this, I propose integrating
Groebner.jl, it could fix #70 and #56 .Before this replacement could be plausible, there is a minimal todo to cover:
Groebner.jlover rationalsGroebner.jl: obtaining dimensionality and basis of R/I. This will be used incheck_primalityImplement saturation inGroebner.jlto use it insimplify_field_generators(?)Singular.jlverifies the resulting basis in rationals, andGroebner.jldoes not. Add optional result verification inGroebner.jlSIwithSingular.jlagainst the one withGroebner.jlIn this PR I'll update on the progress in development of those! Please let me know if I'm missing something 🍰