MR for PdfToTextConverter #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oceania2018
reviewed
Aug 25, 2023
| public interface IPdf2TextConverter | ||
| { | ||
| Task<string> ConvertPdfToText(IFormFile formFile, int? startPageNum, int? endPageNum); | ||
| Task<string> OpenPdfDocumentAsync(IFormFile formFile, int? startPageNum, int? endPageNum); |
There was a problem hiding this comment.
I think these 4 functions don't need to be exposed outside. They're used internally. So we can remove these interfaces.
- OpenPdfDocumentAsync
- LocalImageToTextsAsync
- ConvertPdfToLocalImagesAsync
- DeleteTempFile
Oceania2018
reviewed
Aug 25, 2023
| { | ||
| private readonly IKnowledgeService _knowledgeService; | ||
| public KnowledgeController(IKnowledgeService knowledgeService) | ||
| private readonly IPdf2TextConverter _pdf2TextConverter; |
There was a problem hiding this comment.
The converter only be used in FeedKnowledge, so we can get this instance in FeedKnowledge function internally. Don't need to declare it this class level.
Oceania2018
reviewed
Aug 25, 2023
| await formFile.CopyToAsync(stream); | ||
| } | ||
|
|
||
| var document = PdfDocument.Open(filePath); |
There was a problem hiding this comment.
We can keep PdfPig as one of the implementation of IPdf2TextConverter rather than delete it.
added 2 commits
August 28, 2023 10:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.