-
-
Notifications
You must be signed in to change notification settings - Fork 582
add ConversationTimeoutService #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Oceania2018
merged 2 commits into
SciSharp:master
from
seplz:feature/CloseIdleConversations
Nov 15, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
src/Infrastructure/BotSharp.OpenAPI/BackgroundServices/ConversationTimeoutService.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
using BotSharp.Abstraction.Agents.Enums; | ||
using BotSharp.Abstraction.Conversations.Models; | ||
using Microsoft.Extensions.Hosting; | ||
|
||
namespace BotSharp.OpenAPI.BackgroundServices | ||
{ | ||
public class ConversationTimeoutService : BackgroundService | ||
{ | ||
private readonly IServiceProvider _services; | ||
private readonly ILogger<ConversationTimeoutService> _logger; | ||
|
||
public ConversationTimeoutService(IServiceProvider services, ILogger<ConversationTimeoutService> logger) | ||
{ | ||
_services = services; | ||
_logger = logger; | ||
} | ||
|
||
protected override async Task ExecuteAsync(CancellationToken stoppingToken) | ||
{ | ||
_logger.LogInformation("Conversation Timeout Service is running."); | ||
try | ||
{ | ||
while (true) | ||
{ | ||
stoppingToken.ThrowIfCancellationRequested(); | ||
var delay = Task.Delay(TimeSpan.FromMinutes(1)); | ||
try | ||
{ | ||
await CloseIdleConversationsAsync(TimeSpan.FromMinutes(10)); | ||
} | ||
catch (Exception ex) | ||
{ | ||
_logger.LogError(ex, $"Error occurred closing conversations."); | ||
} | ||
await delay; | ||
} | ||
} | ||
catch (OperationCanceledException) { } | ||
} | ||
|
||
public override async Task StopAsync(CancellationToken stoppingToken) | ||
{ | ||
_logger.LogInformation("Conversation Timeout Service is stopping."); | ||
await base.StopAsync(stoppingToken); | ||
} | ||
|
||
private async Task CloseIdleConversationsAsync(TimeSpan conversationIdleTimeout) | ||
{ | ||
using var scope = _services.CreateScope(); | ||
var conversationService = scope.ServiceProvider.GetRequiredService<IConversationService>(); | ||
var hooks = scope.ServiceProvider.GetServices<IConversationHook>() | ||
.OrderBy(x => x.Priority) | ||
.ToList(); | ||
var moment = DateTime.UtcNow.Add(-conversationIdleTimeout); | ||
var conversations = | ||
(await conversationService.GetLastConversations()) | ||
.Where(c => c.CreatedTime <= moment); | ||
foreach (var conversation in conversations) | ||
{ | ||
try | ||
{ | ||
var response = new RoleDialogModel(AgentRole.Assistant, "End the conversation due to timeout.") | ||
{ | ||
StopCompletion = true, | ||
FunctionName = "conversation_end" | ||
}; | ||
|
||
foreach (var hook in hooks) | ||
{ | ||
await hook.OnConversationEnding(response); | ||
} | ||
} | ||
catch (Exception ex) | ||
{ | ||
_logger.LogError(ex, $"Error occurred closing conversation #{conversation.Id}."); | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a flag to mark the conversation has been triggered
hook.OnConversationEnding
?Otherwise next time this conversation will be triggered again?