Skip to content

Twilio optimize #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Twilio optimize #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioVoiceController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,10 @@ public async Task<TwiMLResult> InitiateConversation(ConversationalVoiceRequest r
}

VoiceResponse response = null;
request.ConversationId = $"TwilioVoice_{request.CallSid}";

var instruction = new ConversationalVoiceResponse
{
SpeechPaths = ["twilio/welcome.mp3"],
CallbackPath = $"twilio/voice/{request.ConversationId}/receive/0",
ActionOnEmptyResult = true,
Timeout = 2
ActionOnEmptyResult = true
};
await HookEmitter.Emit<ITwilioSessionHook>(_services, async hook =>
{
Expand All @@ -60,7 +56,8 @@ await HookEmitter.Emit<ITwilioSessionHook>(_services, async hook =>
OnlyOnce = true
});

instruction.CallbackPath = $"{instruction.CallbackPath}?{GenerateStatesParameter(request.States)}";
request.ConversationId = $"TwilioVoice_{request.CallSid}";
instruction.CallbackPath = $"twilio/voice/{request.ConversationId}/receive/0?{GenerateStatesParameter(request.States)}";

var twilio = _services.GetRequiredService<TwilioService>();
if (string.IsNullOrWhiteSpace(request.Intent))
Expand Down Expand Up @@ -109,7 +106,6 @@ public async Task<TwiMLResult> ReceiveCallerMessage(ConversationalVoiceRequest r
var twilio = _services.GetRequiredService<TwilioService>();
var messageQueue = _services.GetRequiredService<TwilioMessageQueue>();
var sessionManager = _services.GetRequiredService<ITwilioSessionManager>();

var messages = await sessionManager.RetrieveStagedCallerMessagesAsync(request.ConversationId, request.SeqNum);
string text = (request.SpeechResult + "\r\n" + request.Digits).Trim();

Expand Down Expand Up @@ -148,7 +144,7 @@ await HookEmitter.Emit<ITwilioSessionHook>(_services, async hook =>
else
{
// keep waiting for user response
if (request.Attempts > 2)
if (request.Attempts > 3)
{
var instruction = new ConversationalVoiceResponse
{
Expand Down Expand Up @@ -187,7 +183,7 @@ await HookEmitter.Emit<ITwilioSessionHook>(_services, async hook =>
ActionOnEmptyResult = true
};

if (request.Attempts == 2)
if (request.Attempts == 3)
{
instruction.SpeechPaths.Add($"twilio/say-it-again-{Random.Shared.Next(1, 5)}.mp3");
}
Expand Down Expand Up @@ -220,7 +216,6 @@ public async Task<TwiMLResult> ReplyCallerMessage(ConversationalVoiceRequest req
var sessionManager = _services.GetRequiredService<ITwilioSessionManager>();
var twilio = _services.GetRequiredService<TwilioService>();
var fileStorage = _services.GetRequiredService<IFileStorageService>();

if (request.SpeechResult != null)
{
await sessionManager.StageCallerMessageAsync(request.ConversationId, nextSeqNum, request.SpeechResult);
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/BotSharp.Plugin.Twilio/Services/TwilioService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public VoiceResponse ReturnNoninterruptedInstructions(ConversationalVoiceRespons
},
Action = new Uri($"{_settings.CallbackHost}/{conversationalVoiceResponse.CallbackPath}"),
SpeechModel = Gather.SpeechModelEnum.PhoneCall,
SpeechTimeout = conversationalVoiceResponse.Timeout > 0 ? conversationalVoiceResponse.Timeout.ToString() : "3",
SpeechTimeout = "auto", // conversationalVoiceResponse.Timeout > 0 ? conversationalVoiceResponse.Timeout.ToString() : "3",
Timeout = conversationalVoiceResponse.Timeout > 0 ? conversationalVoiceResponse.Timeout : 3,
ActionOnEmptyResult = conversationalVoiceResponse.ActionOnEmptyResult
};
Expand Down