Added 'strict' parameter for template retrieval #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trieval of a valid template.
martindevans
requested changes
Mar 7, 2025
martindevans
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check to the
LLamaTemplateconstructor andModel.GetTemplate(), causing it to throw an exception if a valid template was expected to be returned (strict = true) but could not be found.This aims to avoid accidental confusion for users that try to use LLamaSharp's auto-template-formatting functionalities with a model whose template is either not supported or not found (e.g. base model vs instruct model).
The default behaviour can be disabled by passing
strict = falsewhen calling to retrieve the template.