Skip to content

Conversation

SignalRT
Copy link
Collaborator

With this changes I think that it's enought to have only a binary. In this moment I keep the name off the DLL with metal as suffix.

https://github.com/SignalRT/llama.cpp/commit/e36ecdccc8754783f93ad3ac8a09e540101f2ca0

There is other change because .metal file should be in the binaries folder of it doesn't work.

@SignalRT SignalRT marked this pull request as ready for review September 10, 2023 18:48
@martindevans
Copy link
Member

Looks good to me! I can't test this, but if you can confirm it works with and without metal I'm happy to merge it.

@geffzhang
Copy link

I just verified it on a Mac machine
218f44183da691f2c244166a76caf7f

@drasticactions
Copy link
Contributor

Is the idea here to get rid of the Metal specific Nuget and make this the default in the runtime package?

@martindevans
Copy link
Member

I think that's the idea yes, since there's only one MacOS binary after this there's no point splitting it into a separate package.

@drasticactions
Copy link
Contributor

I think that's the idea yes, since there's only one MacOS binary after this there's no point splitting it into a separate package.

It's still supported in their codebase. The underlying implementations are still there, but they switched the CMake files to build with metal by default. So there are still two binaries... that said, if the default is Metal, then that would probably make the most sense to ship by default too, so I'm okay with that.

@SignalRT
Copy link
Collaborator Author

There is another argument as explained in the documentation:

When built with Metal support, you can explicitly disable GPU inference with the --gpu-layers|-ngl 0 command-line
argument.

@Oceania2018 Oceania2018 merged commit f134c5a into SciSharp:master Sep 17, 2023
@SignalRT SignalRT deleted the DefaultMetal branch September 17, 2023 16:31
@martindevans martindevans mentioned this pull request Oct 21, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants