-
Notifications
You must be signed in to change notification settings - Fork 470
Enhance framework compatibility #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance framework compatibility #259
Conversation
Thanks for the PR! I don't think the approach taken here it quite right though. The extension methods covered with You could probably use |
I understand. In my previous testing with Unity, I had found I'll just have Edit: I just updated it! |
Thanks for fixing that so quickly, just a couple of other minor nits I spotted in review :) |
Looks good to me! Just waiting for those tests to run and I'll merge it. Thanks very much :) |
Thank you! You're welcome! |
…hat it shouldn't. Fixed that. Originally from these PRs: - SciSharp#263 - SciSharp#259
Overview:
This pull request enhances framework compatibility of LLamaSharp, addressing some issues discussed in #178.
Changes Made: