Added a converter similar to the Open AI one #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! If you would like to, we'll appreciate it if you could add some unit test about semantic-kernel. Note that this is not a required one, the overall looks very good to me. :) |
|
OK, I can work on some unit tests too, will add here. One other suggestion, I think the ChatRequestSettings class is misnamed, because it doesn't just apply to Chat, it applies to Text as well. I suggest renaming it to LlamaRequestSettings. |
|
Thank you for this contribution! :) |
|
I was struggling with this very issue just now. Thanks for the great pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all based on the same classes in their OpenAI implementation. I tested it with a couple of Microsoft's sample projects in Semantic Kernel, and it seems to work. I didn't see any unit tests for the Semantic Kernel code yet, but if you want to start adding that, I can add some unit tests too.
Fixes #313