Skip to content

bump sk to 1.0.1 & km to 0.18 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 21, 2023
Merged

bump sk to 1.0.1 & km to 0.18 #356

merged 6 commits into from
Dec 21, 2023

Conversation

xbotter
Copy link
Collaborator

@xbotter xbotter commented Dec 11, 2023

No description provided.

@martindevans
Copy link
Member

Looks like it's failing due to the serialization of Encoding. That should be serialized as the name of the encoding, but looks like it's not here for some reason.

@xbotter
Copy link
Collaborator Author

xbotter commented Dec 12, 2023

This looks like an error introduced by upgrading to System.Text.Json 8.0.0.
The sk-rc3 version uses System.Text.Json 8.0.0, and it is currently not possible to downgrade. I will go and see how to resolve this issue.

@xbotter xbotter mentioned this pull request Dec 12, 2023
Merged
@xbotter xbotter marked this pull request as draft December 14, 2023 01:35
@xbotter xbotter changed the title bump sk to 1.0.0-rc3 & km to 0.18 bump sk to 1.0.0-rc4 & km to 0.18 Dec 14, 2023
@xbotter xbotter marked this pull request as ready for review December 14, 2023 01:53
@martindevans
Copy link
Member

I don't really know much about semantic kernel, but from what I can see everything looks good 👍

@martindevans
Copy link
Member

Shall we go ahead and merge this?

@xbotter
Copy link
Collaborator Author

xbotter commented Dec 17, 2023

We can wait a little longer because SK may release version 1.0.0 soon, and I don't know if there will be any breaking changes.

@martindevans martindevans mentioned this pull request Dec 18, 2023
Closed
@xbotter xbotter changed the title bump sk to 1.0.0-rc4 & km to 0.18 bump sk to 1.0.1 & km to 0.18 Dec 19, 2023
@xbotter
Copy link
Collaborator Author

xbotter commented Dec 19, 2023

@martindevans SK has directly jumped to version 1.0.1 and has been updated.

martindevans
martindevans reviewed Dec 19, 2023
View reviewed changes
martindevans
martindevans reviewed Dec 19, 2023
View reviewed changes
@martindevans
Copy link
Member

Just one small thing I noticed, sorry should have caught that in earlier reviews.

martindevans
martindevans requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@martindevans martindevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes in other comments. Just two small changes.

@martindevans
Copy link
Member

Thanks for fixing that. Looks good to merge to me 👍

@martindevans martindevans merged commit f0d7468 into SciSharp:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martindevans martindevans martindevans approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xbotter @martindevans