Update compile.yml to fix not building for windows #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build step: Compile (Windows) (avx512, -DLLAMA_AVX512=ON -LLAMA_AVX512_VBMI=ON -DLLAMA_AVX512_VNNI=ON)
There is a typo in the cmake command: `cmake .. -DLLAMA_NATIVE=OFF -DLLAMA_BUILD_TESTS=OFF -DLLAMA_BUILD_EXAMPLES=OFF -DLLAMA_BUILD_SERVER=OFF -DBUILD_SHARED_LIBS=ON -DLLAMA_AVX512=ON -LLAMA_AVX512_VBMI=ON -DLLAMA_AVX512_VNNI=ON
cmake --build . --config Release -j ${env:NUMBER_OF_PROCESSORS}`
-LLAMA_AVX512_VBMI
Should be
-DLLAMA_AVX512_VBMI
martindevans
approved these changes
Dec 24, 2023
|
Thankyou! I'm sure that would have caused me trouble next time I came to do a binary update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build step: Compile (Windows) (avx512, -DLLAMA_AVX512=ON -LLAMA_AVX512_VBMI=ON -DLLAMA_AVX512_VNNI=ON)
There is a typo in the cmake command:
cmake .. -DLLAMA_NATIVE=OFF -DLLAMA_BUILD_TESTS=OFF -DLLAMA_BUILD_EXAMPLES=OFF -DLLAMA_BUILD_SERVER=OFF -DBUILD_SHARED_LIBS=ON -DLLAMA_AVX512=ON -LLAMA_AVX512_VBMI=ON -DLLAMA_AVX512_VNNI=ON cmake --build . --config Release -j ${env:NUMBER_OF_PROCESSORS}-LLAMA_AVX512_VBMIShould be
-DLLAMA_AVX512_VBMIHere is a link to the build error: https://github.com/edgett/LLamaSharp/actions/runs/7316984325/job/19932084747#logs
And a working build after this change:
https://github.com/edgett/LLamaSharp/actions/runs/7317114102/job/19932341049