Lazy weighted RMS calculation #5017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
commented
Oct 7, 2022
rcomer
commented
Oct 7, 2022
rcomer
force-pushed
the
rms-lazy-weighted
branch
from
1b218ee to
2be06cb
Compare
Member
|
@rcomer do you have time to rebase this PR? 😄 |
Note that the referenced dask issue was fixed by dask#4236 which was included in v1.1.0.
rcomer
force-pushed
the
rms-lazy-weighted
branch
from
6233641 to
1fc6cf7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5017 +/- ##
=======================================
Coverage ? 89.24%
=======================================
Files ? 88
Lines ? 22195
Branches ? 4857
=======================================
Hits ? 19809
Misses ? 1641
Partials ? 745 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ESadek-MO
approved these changes
Feb 27, 2023
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Apr 22, 2023
* upstream/main: (23 commits) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084) removed cell measure mask check and error (SciTools#5181) Updated environment lockfiles (SciTools#5177) Lazy weighted RMS calculation (SciTools#5017) Add coverage badge to README.md (SciTools#5176) Add coverage testing (SciTools#4765) Whats new updates for v3.4.1 . NetCDF thread safety take two (SciTools#5095) Updated environment lockfiles (SciTools#5163) Plugin support (SciTools#5144) Expand scope of common contributor links (SciTools#5159) Replace apparently retired UDUNITS documentation link. (SciTools#5153) [pre-commit.ci] pre-commit autoupdate (SciTools#5150) Fixing typo's in Gitwash. (SciTools#5145) add readme #showyourstripes (SciTools#5141) [pre-commit.ci] pre-commit autoupdate (SciTools#5143) Iris ❤ Xarray docs page. (SciTools#5025) [pre-commit.ci] pre-commit autoupdate (SciTools#5136) Updated citation (SciTools#5116) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Lazy aggregation with weights was not previously implemented for the RMS aggregator because of a bug in the weighted masked case reported at dask/dask#3846 (see removed code comments). This bug was fixed at dask/dask#4236, and the fix included in version 1.1.0. Iris's minimum supported version of Dask is now 2.26.
Consult Iris pull request check list