-
Notifications
You must be signed in to change notification settings - Fork 298
Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation #5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation #5084
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4656b39
First implementation for smarter weighted aggregation
schlunma fcde563
Allowed arbitrary _DimensionalMetadata for weights
schlunma ae4efbb
Added tests
schlunma c3dd61d
Added units argument to constructor of Weights
schlunma 401d49d
Added documentation
schlunma 546f204
Fixed tests and added Weights class to API doc
schlunma c694c4b
Fixed tests again
schlunma 6dff4a8
Fixed bug which lead to errors when weights was explicitly set to None
schlunma c820183
Fixed bug in doc
schlunma b4e2e83
Try 1 to fix doctest
schlunma 43ff2db
Do not import inherited functions for Weights anymore to avoid doctes…
schlunma 8670788
Made Weights class private
schlunma 1b458f9
Suggestions from code review
schlunma 2505fb8
Split tests into smaller parts
schlunma 768a0c4
Re-wrote TestWeights as pytest test
schlunma 0352241
Spellcheck
schlunma af9aaab
Added test for _sum_units_func
schlunma 69a854f
Ensure backwards-compatibility of Aggregator.units_func
schlunma 0741081
Restored import order of test
schlunma fca72f8
Added What's new entry
schlunma 8232c9d
Split further tests
schlunma 9d8a87a
Optimized What's new entry
schlunma d1b9c56
Apply suggestions from code review
schlunma 17885c4
obj cannot be None in _Weights.__array_finalize__
schlunma ab0a20f
Removed whitespace
schlunma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.