-
Notifications
You must be signed in to change notification settings - Fork 297
Tolerant handling of standard_name and dimension coordinate loading
#6338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
trexfeathers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some to-do's I would appreciate input on.
|
I forgot to restore the previous state after my doctests are finished. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6338 +/- ##
==========================================
+ Coverage 89.78% 89.80% +0.02%
==========================================
Files 90 90
Lines 23632 23752 +120
Branches 4411 4418 +7
==========================================
+ Hits 21217 21331 +114
- Misses 1667 1672 +5
- Partials 748 749 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Bit late, but this closes #5171 ! |
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting what I got so far.
Possibly ongoing, though
|
P.S. with a bit more reading, I see that the "new class" idea for LOAD_PROBLEMS causes a lot of problems. |
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty solid !
Just a few small changes. mostly to tests
...iris/tests/unit/fileformats/nc_load_rules/helpers/test_build_and_add_dimension_coordinate.py
Outdated
Show resolved
Hide resolved
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now !
|
Thanks @pp-mo! |
🚀 Pull Request
Description
Closes #6318
To-do
iris.loading.LOAD_PROBLEMSiris.loading.LOAD_PROBLEMS.build_and_add_*iris.loading.LOAD_PROBLEMSand the new warningDeviation from the original spec
To avoid making too many enhancements to
actions.py- which we consider legacy (#6316) - I decided it was better to create new routines for adding elements to theCube, and house them inhelpers.py, with the rest of the non-Pyke code. If the reviewer is happy with this approach, I will rewrite the spec in the issues.Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: