Skip to content

Lib as NPM package + reorganisation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 19, 2022
Merged

Lib as NPM package + reorganisation #1

merged 20 commits into from
May 19, 2022

Conversation

@OlegGulevskyy
Copy link
Collaborator

@OlegGulevskyy OlegGulevskyy commented May 18, 2022 •
edited
Loading

  • Making the library as a package
  • Adding long standing PR to permanently remove temporary files
  • Simple folder org with its each own readme file for each App
  • Added dependency library ImgApp as well as the library heavily relies on it

Deployments are working although manual, without CI yet

Continuation of the library support as the original repo does not seem to be active since its initial commit.

@OlegGulevskyy OlegGulevskyy requested a review from kengenouel May 18, 2022 16:34
@OlegGulevskyy OlegGulevskyy self-assigned this May 18, 2022
@OlegGulevskyy OlegGulevskyy changed the title Lib as NPM packages + reorganisation Lib as NPM package1 + reorganisation May 18, 2022
@OlegGulevskyy OlegGulevskyy changed the title Lib as NPM package1 + reorganisation Lib as NPM package + reorganisation May 18, 2022
kengenouel
kengenouel approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@kengenouel kengenouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files have 3 "p" to App like SlideAppp.js

@OlegGulevskyy
Copy link
Collaborator Author

OlegGulevskyy commented May 19, 2022

Some files have 3 "p" to App like SlideAppp.js

This is to avoid conflicts with Google apps that have the same name (DocumentApp, SpreadsheetApp etc)

@OlegGulevskyy OlegGulevskyy merged commit 0f51531 into master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kengenouel kengenouel kengenouel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@OlegGulevskyy OlegGulevskyy

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OlegGulevskyy @kengenouel