Have PostgresQuerySet.insert always return the primary key
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes SectorLabs#48 and ensures that objects which specify an explicit primary key value will have that value returned from 'insert'. This makes `insert` reliably usable for models which don't have an `id` field (which previously `AttributeError`ed or returned `None`, depending on whether a conflict was anticipated). Note: this is potentially quietly breaking for models which: - specified a non-`id` primary key, and - also had a separate `id` field This scenario seems sufficiently unlikely to be worth the fix.
Photonios
approved these changes
Jun 19, 2018
Contributor
|
Many thanks and my apologies for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #48 and ensures that objects which specify an explicit primary key value will have that value returned from 'insert'.
This makes
insertreliably usable for models which don't have anidfield (which previouslyAttributeErrored or returnedNone, depending on whether a conflict was anticipated).Note: this is potentially quietly breaking for models which:
idprimary key, andidfieldThis scenario seems sufficiently unlikely to be worth the fix.