Skip to content

Conversation

krisvanneste
Copy link
Collaborator

Claudio,

Here is a branch with a first version of a ssp_clear_state function.
It resets some global variables caching information in different submodules. Optionally, config.options can be cleared and config can be reset to the default values.
More testing is still needed (involving multiple runs with different data/settings).
Can you have a look and improve it?

@claudiodsf claudiodsf changed the base branch from main to v2 January 10, 2025 13:05
@claudiodsf
Copy link
Member

Thanks Kris!

I'll look into that later today or early next week.

Could you please send me by email the latest version of your working notebook example?

P.S. I changed the destination branch of this PR from main to v2 😉

@krisvanneste
Copy link
Collaborator Author

P.S. I changed the destination branch of this PR from main to v2 😉

Sorry, that's causing the conflicts of course. Github presented me with a PR proposal and I clicked on it...

@krisvanneste
Copy link
Collaborator Author

Could you please send me by email the latest version of your working notebook example?

OK, I will clean up some stuff first.
Shall I send it by mail or in this thread?

@krisvanneste
Copy link
Collaborator Author

Could you please send me by email the latest version of your working notebook example?

OK, I will clean up some stuff first. Shall I send it by mail or in this thread?

What is the name of the notebook I sent you earlier?

@claudiodsf
Copy link
Member

I think it was run_ssp_from_asdf.ipynb.

Maybe we can iterate by mail on the notebook (and the required data)

@claudiodsf
Copy link
Member

Hi Kris,
I rebased and force-pushed this PR and made some additional modification, which you can check in the commits.

The most important thing is that the first option of ssp_clear_state() is called now reset_config instead of clear_config, since we don't really want to fully clear the config object.

Let me know if that's ok for you, so that I can merge this one.

Thanks!

@krisvanneste
Copy link
Collaborator Author

Thanks for reopening this. I will inspect it next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants