Bug fix: Foreach command in selenium-side-runner #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed side-runner foreach command
Fixed the for each test.
Fixed failed test for Foreach bug fix
JitendraMishra2010
approved these changes
Jul 24, 2019
|
Hi @tourdedave ! This is the last and final PR for the small bug. Thank you in advance for reviewing! |
|
Thanks for the PR! I'll review soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selenium side runner had an off by one bug in the foreach command. When looping through an array it would miss the last element of the array.
The underlying problem of this error was found in selianize/src/command.js file, where the loop of the array was written "for (let i = 0; i < vars["collection"].length -1; i++)" instead of "for (let i = 0; i < vars["collection"].length; i++)". This caused the program to not loop through the last element of the array when running the foreach command with the selenium-side-runner.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement