Skip to content

[java] timely get rid of the SelectorManager threads #11283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[java] timely get rid of the SelectorManager threads #11283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,5 +300,14 @@ public HttpClient createClient(ClientConfig config) {
Objects.requireNonNull(config, "Client config must be set");
return new JdkHttpClient(config);
}

@Override
public void cleanupIdleClients() {
HttpClient.Factory.super.cleanupIdleClients();

// The SelectorManager thread uses internally a WeakReference to the HttpClient to check if it
// is still used or the thread can be stopped. Calling the GC will clear the WeakReference.
System.gc();
}
}
}