test(mixed): add test for content prop, remove useless tests
#2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2017 11:59
layershifter
changed the title
content prop, remove useless tests
added 4 commits
October 1, 2017 10:25
… add missing props
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
+ Coverage 99.73% 99.73% +<.01%
==========================================
Files 151 151
Lines 2611 2624 +13
==========================================
+ Hits 2604 2617 +13
Misses 7 7
Continue to review full report at Codecov.
|
layershifter
commented
Oct 2, 2017
3 tasks
Member
|
Unblocked, needs conflicts resolved. |
…React into tests/content # Conflicts: # src/elements/Step/StepContent.js # src/elements/Step/StepGroup.d.ts # src/elements/Step/StepGroup.js # test/specs/views/Stastistic/Statistic-test.js # test/specs/views/Stastistic/StatisticLabel-test.js # test/specs/views/Stastistic/StatisticValue-test.js
layershifter
commented
Oct 10, 2017
Member
Author
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
@levithomason I solved merge conflicts, ready for review 👍
Member
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by #1879.
Requires #2145.
Requires #2152.
What?
In #1364 we decided that each component that has
childrenshould also havecontentprop.This PR:
content(fewer changes in feat(Ref): implementinnerRefon all components #1879)contentprop (same as forchildren)contentprop to all components that missing it