This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Brian/require successful transfer #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
force-pushed
the
brian/require_successful_transfer
branch
2 times, most recently
from
da34df3 to
475c407
Compare
…urned. Tidied up transferProxy specs.
asoong
force-pushed
the
brian/require_successful_transfer
branch
from
475c407 to
21b551c
Compare
asoong
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left one before statement in transferProxy on the approve function because we're toggling something outside the control of the subject it needs to run before the beforeEach set-up statement in each test.