Skip to content

Conversation

@lopert
Copy link
Contributor

@lopert lopert commented Nov 11, 2025

WHY are these changes introduced?

Helper branch for testing function's https://github.com/Shopify/shopify-function-javascript dep during generation.

Swaps out what's defined by the template with relevant test version.

This PR is just to trigger snapit.

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@lopert lopert force-pushed the lopert.shopify_function-dep-tester branch from 894ab5b to ac8a3cf Compare November 11, 2025 16:25
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.22% (-0.01% 🔻)
13585/17149
🟡 Branches
73.11% (+0% 🔼)
6634/9074
🟡 Functions 79.37% 3505/4416
🟡 Lines
79.57% (-0.01% 🔻)
12830/16124
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / extension.ts
87.5% (-3.61% 🔻)
69.23% (-3.69% 🔻)
91.67%
87.23% (-3.68% 🔻)

Test suite run success

3356 tests passing in 1372 suites.

Report generated by 🧪jest coverage report action from b05fad4

@lopert lopert changed the title [DNM] swap shopify_function dep from template to local tarball [DNM] swap shopify_function dep from template to snapshot Nov 11, 2025
@lopert
Copy link
Contributor Author

lopert commented Nov 11, 2025

/snapit

@lopert lopert marked this pull request as ready for review November 11, 2025 17:25
@lopert lopert requested a review from a team as a code owner November 11, 2025 17:25
@lopert
Copy link
Contributor Author

lopert commented Nov 11, 2025

/snapit

@github-actions
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@lopert lopert force-pushed the lopert.shopify_function-dep-tester branch from 50e6a88 to b05fad4 Compare November 12, 2025 13:59
@lopert lopert marked this pull request as draft November 12, 2025 13:59
@lopert
Copy link
Contributor Author

lopert commented Nov 12, 2025

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @lopert! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/[email protected]

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant