Support for v2 of Wasm API #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcharles
force-pushed
the
jc.wasm-api-v2
branch
from
46309d1 to
ba01fe1
Compare
adampetro
approved these changes
Sep 25, 2025
| fn main() { | ||
| eprintln!("Invoke a named import"); | ||
| std::process::exit(1); | ||
| process::abort() |
Contributor
There was a problem hiding this comment.
Would it be good to keep a log!("Invoke a named export"); here?
Contributor
Author
There was a problem hiding this comment.
I'll add that. Shouldn't really matter too much given it's an example but no harm in having it.
shopify_function/src/lib.rs
Outdated
| ($($args:tt)*) => { | ||
| { | ||
| use std::fmt::Write; | ||
| let mut buf = String::new(); |
Contributor
There was a problem hiding this comment.
Would it be good macro hygiene to make this std::string::String?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new Wasm API. Adds a
log!macro to log things.