Skip to content

Use ryu to serialize Decimal #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

Use ryu to serialize Decimal #63

merged 1 commit into from
May 7, 2024

Conversation

adampetro
Copy link
Contributor

ryu is used by serde_json, so we are already including the f64 serialization logic in our binaries. Replacing the Decimal implementation of Into<String> to make use of ryu means that we can save ~20KB in binary size.

The example on main: 165KB
The example on this branch: 142KB

@adampetro adampetro requested a review from jbourassa May 7, 2024 00:23
@adampetro adampetro mentioned this pull request May 7, 2024
Merged
@adampetro adampetro merged commit 9ab7407 into main May 7, 2024
@adampetro adampetro deleted the ap.decimal-ryu branch May 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jbourassa jbourassa jbourassa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adampetro @jbourassa