allow to configure pr title, commit message, and branch name #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
reviewed
Oct 30, 2024
| repoSync.AddTargetRepository(new(credentials, Client.RepositoryOwner, "GitHubSync.TestRepository", repoContext.TempBranchName)); | ||
|
|
||
| var sync = await repoSync.Sync(); | ||
| var sync = await repoSync.Sync( |
There was a problem hiding this comment.
shouldnt these be in new tests?
There was a problem hiding this comment.
do you mean to make the GitHubSync* messages the defaults for prTitle, branchName, & commitMessage? or create new tests which don't use the previous defaults?
SimonCropp
reviewed
Oct 30, 2024
| branch: "master")); | ||
|
|
||
| // Run the sync | ||
| await repoSync.Sync(syncOutput: SyncOutput.MergePullRequest); |
There was a problem hiding this comment.
can this be part of a new snippet
There was a problem hiding this comment.
should prTitle, branchName, & commitMessage for the Sync method in the RepoSync class be optional params with default values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: the
branchparameter of theCreateCommitmethod is not used in theGitHubSynclibrary, but I needed it in myGitLabSynclibrary.