Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #999 and adds addition ResizeHelper tests

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #1003 into master will decrease coverage by 0.13%.
The diff coverage is 76.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   89.77%   89.64%   -0.14%     
==========================================
  Files        1098     1098              
  Lines       48810    48862      +52     
  Branches     3433     3430       -3     
==========================================
- Hits        43821    43802      -19     
- Misses       4284     4310      +26     
- Partials      705      750      +45
Impacted Files Coverage Δ
...geSharp.Tests/Processing/Transforms/ResizeTests.cs 100% <100%> (ø) ⬆️
...cessing/Processors/Transforms/ResizeHelperTests.cs 100% <100%> (ø) ⬆️
.../ImageSharp.Tests/Processing/Transforms/PadTest.cs 100% <100%> (ø) ⬆️
...ssors/Transforms/Resize/ResizeProcessor{TPixel}.cs 95.91% <100%> (ø) ⬆️
src/ImageSharp/Processing/ResizeOptions.cs 100% <100%> (ø) ⬆️
...ng/Processors/Transforms/Resize/ResizeProcessor.cs 94.11% <100%> (+8.4%) ⬆️
...ssing/Processors/Transforms/Resize/ResizeHelper.cs 50.61% <47.67%> (+5%) ⬆️
...ests/TestUtilities/ImageProviders/SolidProvider.cs 37.93% <0%> (-20.69%) ⬇️
tests/ImageSharp.Tests/TestUtilities/TestType.cs 60% <0%> (-20%) ⬇️
...ests/ImageSharp.Tests/TestUtilities/TestVector4.cs 48% <0%> (-20%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceff1cc...0cc178d. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #1003 into master will increase coverage by 0.04%.
The diff coverage is 77.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   89.81%   89.86%   +0.04%     
==========================================
  Files        1098     1098              
  Lines       48790    48851      +61     
  Branches     3429     3428       -1     
==========================================
+ Hits        43821    43898      +77     
+ Misses       4264     4252      -12     
+ Partials      705      701       -4
Impacted Files Coverage Δ
...geSharp.Tests/Processing/Transforms/ResizeTests.cs 100% <100%> (ø) ⬆️
...cessing/Processors/Transforms/ResizeHelperTests.cs 100% <100%> (ø) ⬆️
.../ImageSharp.Tests/Processing/Transforms/PadTest.cs 100% <100%> (ø) ⬆️
src/ImageSharp/Processing/ResizeOptions.cs 100% <100%> (ø) ⬆️
...ageSharp/Processing/Extensions/ResizeExtensions.cs 100% <100%> (ø) ⬆️
...ng/Processors/Transforms/Resize/ResizeProcessor.cs 100% <100%> (+14.28%) ⬆️
...ssors/Transforms/Resize/ResizeProcessor{TPixel}.cs 95.91% <100%> (ø) ⬆️
...ssing/Processors/Transforms/Resize/ResizeHelper.cs 51.74% <50%> (+6.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafba05...73f3c7a. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never spent enough time to fully understand these resize modes, but since nothing new is happening (we are just extending the first constructor, with the logic already present in the first one), I assume there is nothing wrong here.
I have a few remarks though.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just perfect now, let's merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resize (ResizeMode.Max) only with height restraint producing image 1px too tall?

2 participants