-
-
Notifications
You must be signed in to change notification settings - Fork 888
Fix #999 and add tests #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #999 and add tests #1003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
- Coverage 89.77% 89.64% -0.14%
==========================================
Files 1098 1098
Lines 48810 48862 +52
Branches 3433 3430 -3
==========================================
- Hits 43821 43802 -19
- Misses 4284 4310 +26
- Partials 705 750 +45
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
+ Coverage 89.81% 89.86% +0.04%
==========================================
Files 1098 1098
Lines 48790 48851 +61
Branches 3429 3428 -1
==========================================
+ Hits 43821 43898 +77
+ Misses 4264 4252 -12
+ Partials 705 701 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never spent enough time to fully understand these resize modes, but since nothing new is happening (we are just extending the first constructor, with the logic already present in the first one), I assume there is nothing wrong here.
I have a few remarks though.
src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeHelper.cs
Outdated
Show resolved
Hide resolved
src/ImageSharp/Processing/Processors/Transforms/Resize/ResizeProcessor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just perfect now, let's merge.
Prerequisites
Description
Fixes #999 and adds addition
ResizeHelpertests